Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacuum platform #425

Closed
wants to merge 73 commits into from
Closed

Conversation

unfilet
Copy link

@unfilet unfilet commented Mar 29, 2021

  • merge master branch
  • update vacuum module

ultratoto14 and others added 30 commits November 9, 2020 13:39
* Introduced time-difference-based method for cover fake positioning
* Time-difference-based method for cover fake positioning now supports also movement inversion
FIx wrong check that enables music mode every time.
Use color picker white point to switch to white mode.
Note added to README regarding unresponsive devices on an internet connected network, correct method of blocking.
Co-authored-by: Kendell R <KTibow@users.noreply.github.com>
* Add support for passive devices

* Fix a few issues

* Fix broken handling of closing a connection

This fixes the following error:

  AttributeError: 'NoneType' object has no attribute 'write'

* Always use discovery broadcasts to trigger connects

From now on there's no connect loop but all attempts are initiated by
received discovery messages.

* Fix cancelling of heartbeat task

* Verify entry has been loaded before connecting

* Don't reset seqno when switching to type_d device
Forgot to add an await to the close method in pytuya when validating the
device. This results in the connection never being closed after adding a
device, giving "connection resets" until the connection fails, the
device or Home Assistant is restarted.
ultratoto14 and others added 24 commits December 17, 2020 21:46
* Introduced read/store to JSON file of cover's last position for fake positioning
* renamed "fake" positioning to "timed"; introduced timed movement timeout equal to full opening time
* Made waiting for timeout for stopping non-blocking
* Introduced status storing using RestoreEntity
* Fixed postlund's remarks
* Updated cover samples in README and info.md
…lues-for-fan

allow set small / large values for low and high speed for fans
Bumps [mypy](https://github.com/python/mypy) from 0.790 to 0.800.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.790...v0.800)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Make connection retries every minute

This mimics the re-connect loop previosuly present, but in a simpler
form. Every 60 seconds, a new connection attempt is made as well as
initially when a device is set up.

* Fix device look up in reconnect loop
Bumps [pylint](https://github.com/PyCQA/pylint) from 2.6.0 to 2.7.2.
- [Release notes](https://github.com/PyCQA/pylint/releases)
- [Changelog](https://github.com/PyCQA/pylint/blob/master/ChangeLog)
- [Commits](pylint-dev/pylint@pylint-2.6.0...pylint-2.7.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Pierre Ståhl <pierre.staahl@gmail.com>
Bumps [mypy](https://github.com/python/mypy) from 0.800 to 0.812.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.800...v0.812)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Pierre Ståhl <pierre.staahl@gmail.com>
@postlund
Copy link
Collaborator

postlund commented Apr 1, 2021

What is the state of this? Compared to #111?

@unfilet
Copy link
Author

unfilet commented Apr 1, 2021

What is the state of this? Compared to #111?

I merged master branch into vacuum_platform.
Fix initialization method
Update some methods parameters.
That's all.

I didn't have time to bring everything back to normal.

@postlund
Copy link
Collaborator

postlund commented Apr 1, 2021

It by would be a lot better if you worked towards master instead of merging on top of the existing PR (we can close that if you take over the work). It's impossible to do any review now as the diff contains lots of unrelated changes, so I don't really see what has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants